A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5
stars
2
forks
source link
Optional seed in `MillipedeWilks` traysegment #246
It seems to me that we can get rid of the additional argument, and just default to updating the steps according to cfg.OUTPUT_PARTICLE_NAME (?)
@tianluyuan I am taking care of this as part of #244 since I have to modify the traysegment arguments nevertheless. Let me know if you have comments.
I see this is a bit more tricky than I thought, because the "steps" live at the segment instance scope, while the frame is accessible only when the segment is run. Probably the most idiomatic way of doing this would be to store the steps inside the frame? This goes a bit beyond the scope of #244 and is rather connected to #230
The current
MillipedeWilksrecotraysegmenttakes an optional seed: https://github.com/icecube/skymap_scanner/blob/c0d20ef1c4119419dfed2967fce569d6ed55a3bd/skymap_scanner/recos/millipede_wilks.py#L257-L260Currently, that argument is hardcoded to: https://github.com/icecube/skymap_scanner/blob/c0d20ef1c4119419dfed2967fce569d6ed55a3bd/skymap_scanner/client/reco_icetray.py#L158
It seems to me that we can get rid of the additional argument, and just default to updating the steps according to
cfg.OUTPUT_PARTICLE_NAME(?)@tianluyuan I am taking care of this as part of #244 since I have to modify the traysegment arguments nevertheless. Let me know if you have comments.I see this is a bit more tricky than I thought, because the "steps" live at the segment instance scope, while the frame is accessible only when the segment is run. Probably the most idiomatic way of doing this would be to store the steps inside the frame? This goes a bit beyond the scope of #244 and is rather connected to #230