search

icecube / skymap_scanner

A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5 stars 2 forks source link

[minor] Download baseline GCDs in Dockerfile and bump to icetray 1.9.1 #258

Closed tianluyuan closed 6 months ago

tianluyuan commented 6 months ago

This requires a icetray 1.9.1 image to be built still.

closes #252

dsschult commented 6 months ago

Building the 1.9.1 icetray here: https://github.com/WIPACrepo/docker-icecube-icetray/actions/runs/7302075179/job/19900005995

dsschult commented 6 months ago

On one hand, I like putting the data in the image so that it is versioned. On the other hand, we may be carrying extra weight. @tianluyuan how much does this change increase the image size?

It's about 600MB right now.

tianluyuan commented 6 months ago

On one hand, I like putting the data in the image so that it is versioned. On the other hand, we may be carrying extra weight. @tianluyuan how much does this change increase the image size?

It's about 600MB right now.

Isn't it also already in the existing images now that are built on top of the icetray with the baseline GCDs?

dsschult commented 6 months ago

On one hand, I like putting the data in the image so that it is versioned. On the other hand, we may be carrying extra weight. @tianluyuan how much does this change increase the image size?

It's about 600MB right now.

Isn't it also already in the existing images now that are built on top of the icetray with the baseline GCDs?

I believe so. I'm not actually too concerned when the image is on CVMFS, as it gets deduped. It just takes longer to build, push, and pull the images, so CI always takes longer. It's not a huge problem, but something to be aware of.