icecube / skyreader

An API for Results Produced by SkyDriver & the Skymap Scanner
MIT License
0 stars 0 forks source link

Do not store metadata in `dtype` #15

Open mlincett opened 1 year ago

mlincett commented 1 year ago

It seems we use the numpy dtype.metadata to carry (event) metadata over in the nside dictionary.

I find pretty counter-intuitive to have metadata of the data embedded in the dtype, but I understand this may be the only numpy-supported way for storing metadata in npz files.

Since we are moving towards JSON as a primary exchange format, I suggest to migrate all the dtype.metadata logic in to_npz() and read_npz(), so that this "feature" is no longer part of the core class design.