Area calculation spherical space

icecube / skyreader

An API for Results Produced by SkyDriver & the Skymap Scanner

MIT License

0 stars 0 forks source link

Area calculation spherical space #36

Closed G-Sommani closed 3 months ago

G-Sommani commented 3 months ago

First part of pull request #35, as an answer to Tianlu's suggestion.

The estimation with Gauss-Green's theorem takes now into account the spherical space. The estimation by counting pixels is therefore now dropped.

G-Sommani commented 3 months ago

Can you try removing # flake8: noqa for at least this file? It provides a lot of useful feedback. If you do, you probably want to attempt this in #35, so you don't have to deal with a manual merge mess.

Yes, I can remove # flake8: noqa from this file. I will do it in #35 after I merge this pull request.

G-Sommani commented 3 months ago

@ric-evans should I merge this pull request and than work on #35?