icecube / skywriter

Upstream Tools for SkyDriver & the Skymap Scanner
MIT License
0 stars 0 forks source link

Issue with `from icecube.icetray import I3Tray` in container #13

Closed mlincett closed 11 months ago

mlincett commented 11 months ago

When running against a modern IceTray installation one gets a warning about from I3Tray import I3Tray being deprecated.

However in CI from icecube.icetray import I3Tray fails due to I3Tray not having an Add attribute.

Currently I had to revert PR #7 to the old-style import for the sake of CI testing.

mlincett commented 11 months ago

@dsschult any suggestion?

dsschult commented 11 months ago

It looks like the docker image is at least 6 months old, and you should use the icetray-prod-current-ubuntu22.04-X64 tag.

dsschult commented 11 months ago

I'd probably ask @briedel why the -X64 got added to the tag name, and the generic tag no longer works.

kjmeagher commented 11 months ago

also that warning is completely harmless, but you should upgrade to the latest icetray

mlincett commented 11 months ago

Will be fixed in #15 , thanks to all for the inputs!