Sorry in advance for turning a one line fix into this, but I just kept finding unrelated bugs, while I was checking if the initial fix had any bugs and just kept fixing them.
These fixes include:
The initial fix for having the text input only trigger on mouse hover
Each number input would trigger two messages to be emitted, instead of just one. The first was explicitly triggered by shell.publish and the second one was from the text input parsing the same event one line later via self.content.on_event, which triggered it's on_input function.
The selection replace/delete logic had an off by one error, which just resulted in the replacement being skipped, if the selection contained the last character. The seconds parsing of the event by the textinput would then however parse the selection “correctly” and send a different message with a different value, than the first. As that value would be emitted later, it would overwrite the first value
This leads to any selection replacement of the last character to be accepted. Meaning, that values > max, or < min could be set, as every max would effectively have a 9 and a min of 0 as the last digit no matter what the actual max value is
Similarly negative max bounds, could have their value set to zero, by selecting and deleting the current value
The delete key could be used to set any value, by either deleting the ‘-’ char to turn negative numbers positive, or deleting the ‘.’ to turn fractions into large numbers, as these inputs were not checked at all
I was losing track of where which event part was handled, so I repackaged all of it into mainly one match and only pass keyboard events to the textinput, that are correctly checked
To make the testing for myself easier, I also added the ability to use ctra+a,v,c & accept '-' as a key input
There is still some minor jank around negative numbers and bounds that do not contain 0, but I am pretty sure these things could only be solved by not passing the event to the child/text for inserts/deletes, which would require reimplementing a bunch of selection & cursor movement logic
Sorry in advance for turning a one line fix into this, but I just kept finding unrelated bugs, while I was checking if the initial fix had any bugs and just kept fixing them.
These fixes include:
shell.publishand the second one was from the text input parsing the same event one line later viaself.content.on_event, which triggered it's on_input function.I was losing track of where which event part was handled, so I repackaged all of it into mainly one match and only pass keyboard events to the textinput, that are correctly checked
To make the testing for myself easier, I also added the ability to use ctra+a,v,c & accept '-' as a key input
There is still some minor jank around negative numbers and bounds that do not contain 0, but I am pretty sure these things could only be solved by not passing the event to the child/text for inserts/deletes, which would require reimplementing a bunch of selection & cursor movement logic
Closes #232