icedman / dash2dock-lite

A minimal and animated implementation of dash to dock
GNU General Public License v3.0
199 stars 16 forks source link

Regression: Various graphical defects #115

Closed joshqou closed 5 months ago

joshqou commented 6 months ago

Updated from b81f786ee91f5bd77cbebbbdb5b5343d6eadc609 to ebc16577a39e3e6a8be0fd57a1b6e7839af51fdf and I'm getting some weird rendering artifacts. Primarily overly pixelated icons, icons losing their bottom padding, and render tearing

image

image

There was also a very odd bug where the icon's containers would be stretched upwards (visible somewhat in the image) for small icon sizes with shrink icons enabled, however I can't seem to reproduce that after resetting extension settings.

icedman commented 6 months ago

I saw this once or twice. But could not reproduce anymore.

I reverted a change which possibly caused this. You try the next commit. And play around the icon sizes and icon quality. To see what might cause this.

FrancescoCaracciolo commented 6 months ago

I had the same issue, installing from current main branch fixed it

FrancescoCaracciolo commented 6 months ago

Nevermind, I have this problem again immagine

icedman commented 6 months ago

Nevermind, I have this problem again immagine

Please also try resetting the settings.

icedman commented 6 months ago

I reverted another previous change. The icon size is now again constantly recalculated while in animation. This uses a little bit more CPU but seems to fix the pixelated issue.

FrancescoCaracciolo commented 5 months ago

image Default settings, only dash2dock extension enabled, main branch If it's useful, OS: Arch Linux, Gnome version: 46, screen resolution 1080p, scaling 100%

icedman commented 5 months ago

Could you check the logs if an error occurred somewhere

icedman commented 5 months ago

Oh.. main branch.. I have not pushed to the main branch yet.. will do after go through my checklist

FrancescoCaracciolo commented 5 months ago

Could you check the logs if an error occurred somewhere

How do I check the logs?

Oh.. main branch.. I have not pushed to the main branch yet.. will do after go through my checklist

Do I need to test the development branch?

icedman commented 5 months ago
journalctl /usr/bin/gnome-shell -f -o cat

Watch the log while running the extension. And look for errors the moment the icons become pixelated.

I haven't seen pixelation error since I reverted some changes. But it is in the development branch yet. I would really help if you could check it out. So I could close the issue.

icedman commented 5 months ago

Also, are you using PNG icons. Try SVG icons see if there is any difference.

FrancescoCaracciolo commented 5 months ago

Still on main branch I switched to default adwaita icons before (default icon quality, no log) Only the gnome-extensions icon seems pixelated for some reason, but it's good looking overall image While the extension is enabled, I switched icon pack back to tela icon pack it was way more pixelated image And then switching back to adwaita (they are now way more pixelated): image All of this with default icon quality (the behavoir is pretty similar even with a different icon quality) Here are the log white I did all of this: https://pastebin.com/3h1BRDbd

icedman commented 5 months ago

Thank you. This is helpful.

icedman commented 5 months ago

I merged the development branch to main. This still has a few issues. - But not of them are nastier than that pixelation bug.

icedman commented 5 months ago

Did a coding binge last night to fix these pixelated icons bug. Please checkout the development branch.

fekzol commented 5 months ago

With disabled animations there are some annoying black backgrounds behind the icons. How can I get rid of them? Had not found any color setting for that. Screenshot from 2024-04-09 19-26-53

icedman commented 5 months ago

Looks like a css style from your OS. This will have to be overriden by the extension. I will include in the next release.