search

icedman / dash2dock-lite

A minimal and animated implementation of dash to dock
GNU General Public License v3.0
199 stars 16 forks source link

Scroll on minimized app icon should bring it up #71

Closed TheWeirdDev closed 10 months ago

TheWeirdDev commented 12 months ago

Currently when you scroll on an app icon that's minimized, nothing happens (It's very confusing). But user expects it to show up.

Showing the window is also how Dash to dock works, so it would be nice if the two extensions behaved similarly.

icedman commented 12 months ago

dash2dock lite actually has some more controls on the icons than dash to dock. you just need to get used to them. minimize/restore > click maximize/restore > shift+click open new window > control+click scroll-up down > cycle windows (if more than one window is open)

TheWeirdDev commented 12 months ago

I know but when the window is minimized it does not un-minimize on scroll. By looking at the code I see you call unminimize but I do not see any effect. The window stays minimized.

Maybe you should call Main.activateWindow(w)?

Edit: After testing more I see cycling windows is broken too. When I scroll on an icon the app is shown but scrolling again will not cycle through windows and only the first window stays focuesd.

icedman commented 12 months ago

Ok. Will check these bugs.

icedman commented 12 months ago

Fixed on the development branch. I also uploaded to EGO, awaiting review.

TheWeirdDev commented 12 months ago

Thanks. I tried it and it works much better now. There is only one issue. When there is only one window of an application, un-minimize still does not work but when I have multiple windows it works.