search

icedream / go-footballdata

Golang interface allowing to communicate with the Football-Data API to process football/soccer match information.
19 stars 6 forks source link

made team name fix #7

Closed Kavit900 closed 7 years ago

Kavit900 commented 7 years ago

So @icedream I dig more deeper and found out that the team name and crest uri for some teams like "Reading" are both set to null and it's not after decoding, if you place a fmt.Println() on the buffer that is present inside the doJson() method i.e the result being returned from the get request you will see that the team and crest uri attribute are both being set to null for some teams, so my guess is there is something wrong with the football.org REST API and for some reason instead of sending the team name inside of TeamName attribute, it sends team name in team attribute, so for now that is the only fix, I have pushed with this branch because from my research it seems there isn't any problem with your code. Let me know if there is anything else that I can work on cheers.

Kavit900 commented 7 years ago

@icedream how much time does it take for these tests to run?

icedream commented 7 years ago

LGTM. I'll do some more checks later on my end, thanks again for the pull request!

Kavit900 commented 7 years ago

Thanks @icedream ya let me know more about it and eagerly waiting for this version to come out soon, I am also working on an app that consumes your api :)