icefoganalytics / travel-authorization

0 stars 0 forks source link

Travel summary bar grey out #154

Closed dpdavids closed 2 months ago

dpdavids commented 5 months ago

On a travel auth the top bar has purpose and dates etc. It looks like I should be able to edit these items (which I can't and that is correct) I am hoping we could grey out the fields or something so that it is obvious that the user can't do.

klondikemarlen commented 5 months ago

@dpdavids This is something that I've been wondering for a while. The library we are using Vuetify uses this formatting for "readonly" fields. There is also the "disabled" flag, but the contrast is so low that its very hard to read.

using readonly image

using "disabled" image

I think it might be a good idea to build display read only data completely differently? i.e. instead of making the look like a form field, why not just make it data? Like this but prettier: image

datajohnson commented 4 months ago

I have been using this format for readonly fields and people seem to like it:

image

We can use this format for readonly fields throughout the app.

klondikemarlen commented 4 months ago

That makes sense to me, I even started using this pattern in the Internal Data Portal independently, so it must be a good pattern!

dpdavids commented 4 months ago

I like it! Sorry for the late response. way to keep it going!

klondikemarlen commented 2 months ago

Completed by @datajohnson in https://github.com/ytgov/travel-authorization/pull/81