search

icefoganalytics / travel-authorization

0 stars 0 forks source link

GL CODING formatting #156

Closed dpdavids closed 5 months ago

dpdavids commented 5 months ago

On the Expense Form (https://travel-auth-dev.ynet.gov.yk.ca/my-travel-requests/84/expense/edit?showEdit=1) Coding Card

Can you update the coding to be accepted with hyphens rather than slashes? Matches other data entry methods eg. 552-123456-2015-1234-12345 rather than 552/123456/2015/1234/12345

a gl can be 26 characters I get the following error when I enter a valid gl code. "General ledger coding update failed: SequelizeDatabaseError: value too long for type character varying(25)"

klondikemarlen commented 5 months ago

@dpdavids It looks like the dashes are included in the size? I was using info from https://www.tpsgc-pwgsc.gc.ca/recgen/pceaf-gwcoa/2223/2-eng.html resulting in a 22 character string. Though I have no idea why I used 25

I can also normalize the data to store support both, but always convert / to -?

dpdavids commented 5 months ago

hey @klondikemarlen the info you are using is from the government canada not yukon government. The format is vote (3 characters) - Program (6 characters) - object code (4 digits) - subledger 1 (0-4 characters) - subleger 2 (0-5 characters)