search

icefoganalytics / travel-authorization

0 stars 0 forks source link

General Ledger Coding Format #160

Closed klondikemarlen closed 5 months ago

klondikemarlen commented 5 months ago

Fixes https://github.com/icefoganalytics/travel-authorization/issues/156

Context

On the Expense Form (https://travel-auth-dev.ynet.gov.yk.ca/my-travel-requests/84/expense/edit?showEdit=1) Coding Card

Can you update the coding to be accepted with hyphens rather than slashes? Matches other data entry methods eg. 552-123456-2015-1234-12345 rather than 552/123456/2015/1234/12345

a gl can be 26 characters I get the following error when I enter a valid gl code. "General ledger coding update failed: SequelizeDatabaseError: value too long for type character varying(25)"

The format is vote (3 characters) - Program (6 characters) - object code (4 digits) - subledger 1 (0-4 characters) - subleger 2 (0-5 characters)

Implementation

Increase size of general ledger code field. Add validation to field in front- and back-end. Add some tests for the validation. Put a bunch of tooltips in the UI.

Screenshots

Create G/L code field image

Edit G/L code field image

Testing Instructions

  1. Run the test suite via dev test (or dev test_api)
  2. Boot the app via dev up
  3. Log in to the app at http://localhost:8080
  4. Go to the My Travel Request page via the top drop down nav.
  5. Create a travel authorization via the "+ Travel Authorization" button.
  6. Fill in the Details section.
  7. Generate the Estimate.
  8. Submit to yourself as the supervisor.
  9. Go to the Manager View via the top drop down nav.
  10. Find your travel request in the "Pending Approvals" section and click on it.
  11. Scroll to the bottom and approve the request.
  12. Go back to the My Travel Request page via the top drop down nav.
  13. Find your travel request in the table and click on it.
  14. Go to the Expense tab.
  15. Scroll down and click on the Add Coding button.
  16. Check out the validation and create a code.
  17. Check out the tooltip on the Coding table.
  18. Click the Edit button on the coding table, check out the validation.
  19. Save the coding.
klondikemarlen commented 5 months ago

Fixes https://github.com/icefoganalytics/travel-authorization/issues/86