search

icefoganalytics / travel-authorization

0 stars 0 forks source link

Cleanup: Wire PreApproved Travel to Travel Details #179

Closed klondikemarlen closed 5 months ago

klondikemarlen commented 5 months ago

Relates to:

Context

In the Approval Region of the travel details tab (https://travel-auth-dev.ynet.gov.yk.ca/my-travel-requests/78/details) can you wire the Pre-approved Travel request drop down to show Approved preapproved travel for a user based on department.

image

Implementation

Normalize preapproved table to travel_authorization_pre_approvals. Normalize a bunch of seeding logic. Make a UI component for selecting travel authorization pre-approvals.

Screenshots

N/A same as previous UI.

Testing Instructions

  1. Run the test suite via dev test (or dev test_api)
  2. Boot the app via dev up
  3. Log in to the app at http://localhost:8080
  4. Select "PreApproved" from the top nav drop down.
  5. Add a new travel pre-approval.
  6. Check that all options render correctly.
  7. After adding the request, select it from the table, and "submit" the selected travel.
  8. Go to the "Submissioins" tab and "approve" the selected travel.
dpdavids commented 5 days ago

Can you add more information to the PreApproved drop down. Conference/meeting - Location - Person(s) if selected