search

icelake-io / icelake

Pure Rust Iceberg Implementation
Apache License 2.0
166 stars 17 forks source link

feat: introduce new writer trait #246

Closed ZENOTME closed 11 months ago

ZENOTME commented 11 months ago

This PR is the 1 step for #243.

It introduces new writer trait and implements it in

  1. rolling writer
liurenjie1024 commented 11 months ago

Is this ready for review or it's still a wip?

ZENOTME commented 11 months ago

Is this ready for review or it's still a wip?

Still a wip

ZENOTME commented 11 months ago

It's ready to review now. But I just implemented it in rolling writer now to make this PR smaller. cc @liurenjie1024

liurenjie1024 commented 11 months ago

LGTM, let's move on.