Closed securechicken closed 5 years ago
Very impressive!
I would prefer smaller PR's in order to test and easier to keep track of changes,
monster PR's is hard to test.
For future reference, the command names is getting longer, MIFARECLASSIC... Maybe start use short like MFC , MFU, etc. The longer the names the less space in the GUI dropdowns.
Is this to be considered WIP or are you ready to merge?
@iceman1001 This was a lot of experimental work, and things are linked together, so having separate PRs would have been really difficult. I rebuilt the whole changes to keep the commits tidy though. On the config names, they are limited by a buffer size in FW, so we will not get any longer (and Ultralight are the longest :p). As regards readiness... I needed that for some tests on my side so... figured it could be nice to push it there as well to demonstrate some possible developments. It is ready, but do not expect much thunder from it though...
So much great effort, bro! Who knows what happens.