Closed ph553 closed 5 years ago
Hello @ph553 Can you please share the first dump you are trying to upload? Are you sure that it doesn't begin with the leading zeroes?
card.txt It was originally in .bin format but i couldnt upload it as a bin file
Ok, it seems that neither in RevE works as it should. Until, it is fixed, the quick and dirty way is to add some zeroes in the beginning of the dump to upload. I tried that to your card.bin (find it attached) and worked for me. card.zip
aha, I see, its the binary loader / eml loader that doesn't different between a proxmark3 dump with header or not... It assumes its a dump file without headers..
private static byte[] ReadFileIntoByteArray(string filename)
{
var fi = new FileInfo(filename);
if (fi.Exists)
{
var dumpStrategy = DumpStrategyFactory.Create(fi.FullName);
var data = dumpStrategy.Read();
if (data.Length < 1024 && data.Length != 320)
data = data.Skip(MifareUltralightCardInfo.PrefixLength).ToArray();
return data;
}
return null;
}
public override byte[] Read() =>
File.ReadAllBytes(FileName);
We would need to add some kind of logic there.
The logic of less than 1024 and not 320, then skip header, isn't good enough I guess. We would need to match more lengths...
This patch tries to solve BIN/EML based uploads with dump files that has or has not a header field inside. ie old dumpfiles from other devices or older proxmark clients.
@ph553 How about you test it out?
@iceman1001 just tested the latest version on both my revG and revE-rebooted. Upload works correctly, but if i download a dump, it still put some bytes filled with 0. I tried reuploading from a dump, but each time i upload-download, it offsets the card data more.
Aha, I didn't look at the download, I am off so I will take a look at when I return.. or @bogiton may do some magic
i think i will add a check if header is all zeros..
test again @ph553 v1.2.0.18 should solve it.
@iceman1001 It works correctly for me, thanks!
Hi I'm currently trying to use the GUI for my rev G, but i've encountered some problems
First of all, when I try to upload a dump to a slot, i get something like the slot 1 in the following image:
while it uploads correctly using teraterm(slot 2). If i read the tag on slot 1, i get an empty card with uid 0000000
Second problem would be while downloading a dump. i get something like
Where the real card would start at the 48th byte
the data from the 112th bytes would be the counters(i guess)
The card data shows empty when read since it is a MIFARE ULTRALIGHT and therefore is only supposed to have 64 bytes of data
Maybe the GUI is writing/checking data at the wrong address?