iceman1001 / ChameleonMini-rebootedGUI

Windows based GUI for Chameleon Mini, the contactless smartcard emulator (NFC/RFID)
GNU General Public License v3.0
294 stars 72 forks source link

Setting slot 8 as active reverts after refresh #145

Closed sawft99 closed 2 years ago

sawft99 commented 2 years ago

Describe the bug

In the GUI and using the built in terminal. If you set slot 8 as active it will take but refreshing or applying the config will revert it to the last slot you had active before that.

To Reproduce:

  1. Select any slot other than 8 and set it as active with the built in terminal or GUI
  2. If you like, refresh/apply/reboot/reconnect/etc...
  3. Set slot 8 to active
  4. The GUI will show the slot as changing and even the lights on the Chameleon change
  5. Refresh/apply/reboot/reconnect/etc...
  6. The active slot is reverted back to the last slot used before trying to make slot 8 active
  7. The lights also revert on the Chameleon

Expected behavior:

Desktop:

Device & Firmware:

iceman1001 commented 2 years ago

There is no active code contributors to this repo any longer. So feel free to contribute, be the change you want to be

Loupetre commented 2 years ago

Hello,

I think I have found the correction to be done. I cannot do a pull request because I have proxy limitation @work.

In FrmMain.cs, function RestoreActiveSlot(), juste change :

if (_active_selected_slot > _tagslotIndexOffset+7) _active_selected_slot = _tagslotIndexOffset+7; by if (_active_selected_slot > _tagslotIndexOffset+7) _active_selected_slot = 8 -_tagslotIndexOffset;

iceman1001 commented 2 years ago

@Loupetre I added your suggestion, if you want to verify it