search

iceman1001 / ChameleonMini-rebootedGUI

Windows based GUI for Chameleon Mini, the contactless smartcard emulator (NFC/RFID)
GNU General Public License v3.0
290 stars 72 forks source link

Add iClass dump detection (2k, as well as default AA1 only dump size) #146

Closed nvx closed 2 years ago

nvx commented 2 years ago

Basic iClass support. Works for 2k full size dumps and iClass AA1 only dumps.

Also changes the behaviour for unknown sized dumps to not change the selected type rather than defaulting to always to mifare classic. This should make it easier in the future to support new card types (select type, then upload dump should work for any new unknown types, assuming the dump size doesn't overlap with an existing card type anyway).

This doesn't add support for dumping the LOCLASS attack data from the ICLASS_DETECTION mode, but I suspect this change alone is useful enough to be merged in going by the number of people in the discord checking out the iClass support in the RRG firmware repo.

iceman1001 commented 2 years ago

hm, no 4096 check for Mifare 4K since your PR changes the default case.

nvx commented 2 years ago

hm, no 4096 check for Mifare 4K since your PR changes the default case.

The MFC 4k check already existed at the top of the switch here:

https://github.com/nvx/ChameleonMini-rebootedGUI/blob/38af56d082cc7eac52eeed77ddaa3e2030048cc5/ChameleonMiniGUI/FrmMain.cs#L2366-L2368

iceman1001 commented 2 years ago

aha, good then