search

iceman1001 / ChameleonMini-rebootedGUI

Windows based GUI for Chameleon Mini, the contactless smartcard emulator (NFC/RFID)
GNU General Public License v3.0
290 stars 72 forks source link

enhancements to GUI #17

Closed iceman1001 closed 6 years ago

iceman1001 commented 6 years ago

@gtpy has used and enhanced our ideas for RevG, and some of which we should adapt. Like the idea of showing a picture of the identifyed device. That would be so easy and still so good.

ref: https://github.com/gtpy/ChameleonMini-RevG-GUI

ghost commented 6 years ago

I tested your GUI with Rev G but it doesn’t work. There are some problems with not identified commands. I’ll analyze it later and do a PR.

iceman1001 commented 6 years ago

Since I don't have RevG , its good that someone who has it can test for us!
Looking forward to see the PR!

iceman1001 commented 6 years ago

@gtpy have you found time to find the cause of the problems?

ghost commented 6 years ago

Not yet. Really much to do in RL. I think I can look at it till end of this week.

Sent from ProtonMail Mobile

AN Di., März 6, 2018 bei 07:43, Iceman notifications@github.com Schrieb:

@gtpy have you found time to find the cause of the problems?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/iceman1001/ChameleonMini-rebootedGUI","title":"iceman1001/ChameleonMini-rebootedGUI","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/iceman1001/ChameleonMini-rebootedGUI"}},"updates":{"snippets":[{"icon":"PERSON","message":"@iceman1001 in #17: @gtpy have you found time to find the cause of the problems?"}],"action":{"name":"View Issue","url":"https://github.com/iceman1001/ChameleonMini-rebootedGUI/issues/17#issuecomment-370680524"}}}

iceman1001 commented 6 years ago

@bogiton Started to add the picture identifying on tab "settings" Two pics RevG and RevE rebooted so far.

Also added context menu to toggle sync scrolling. would need to add it to the hexbox's content menus..

bogiton commented 6 years ago

Pics are a nice addition, indeed! Of course, it is identifying my customized firmware (removed the "MY" extension) wrongly as a RevG, so in regard to future firmware updates maybe we have to use the PID&VID for identifying instead. Yeah, I just saw the context menu item, cool! I will also add it to the hexboxes today.

iceman1001 commented 6 years ago

The firmware name should be modified for the next releases :) and a better detection between official RevG ...

The contextmenu is great.. but I like the addition of "mouseenter" which focuses the hexbox when over it, enableing to scroll directly with mouse-scroll :)

bogiton commented 6 years ago

Ah right, I haven't had that problem, cause I'm using Win10, which does that automatically. But yeah, extremely useful feature. :)

iceman1001 commented 6 years ago

hm, I have that on Win10,.. Try loading a dump and "unselect" the hexbox by clicking on the log textbox, move mouse to hexbox and it doesn't scroll if you deactivate it in the source. In any case, its much more easier to use with it :) The way I like it.

Maybe some borders around the image...

What do you think about the idea of color-templating? So we make a color template for Mifare Classic S50, S20, S70,.. or UL.. Selectable from a dropdown?

bogiton commented 6 years ago

Selection of back/fore colors sounds like a nice touch. Maybe colorpickers would be more user-friendly. We just have to add that twice, one pair for each hexbox. We could put the image inside the "connection status" group box and re-arrange the whole layout of the "Settings" tab a bit.

iceman1001 commented 6 years ago

No, not picking colors, I am thinking on colorizing the memory layouts..

Like this: image

Don't let me stopping you fixing the settings tab :)

bogiton commented 6 years ago

Ah ok, yeah that looks interesting. I'm worried though on how would they pair with the the diff colors we have. After the hexbox context menu, I'll give the settings tab a try!

iceman1001 commented 6 years ago

well, different modes? template mode vs compare mode?
I start a new thread for it.

looking forward to see the context menu, you will need to expose a event and expose the hexbox contentxmeny control property to be able to add a menuitem dynamically

bogiton commented 6 years ago

Yes, exactly. I have it ready actually, I will PR in a few. Will be fitting, for the Chameleon to switch colors :P

iceman1001 commented 6 years ago

LOL I'm closing this one since we have the picture identification.