search

iceman1001 / proxmark3

[Deprecated] Iceman Fork, the most totally wicked fork around if you are into proxmark3
http://www.icedev.se/pm3.aspx
GNU General Public License v2.0
465 stars 116 forks source link

Fix crashes when compiled with a different cpu #103

Closed Gator96100 closed 7 years ago

Gator96100 commented 7 years ago

This will prevent crashes when the client is compiled with a different cpu without affecting the execution time. Execution times(average of 3 runs with the same nonces.bin file): march=native: 32.1s without march: 139.3s march=x86-64: 33.7s

iceman1001 commented 7 years ago

Nice! But than your build env is x86 intel, and distribution of software that executes on multiple platforms is easily many more than you want to. Pushing in this limit into iceman fork is something I'm reluctant. For you bin-distro, I would suggest that you use these aformented params.

To quote what @aczid said about this matter. "my code is not really redistributable as binary, unless you hack in runtime detection or want to ship 3-8 versions 64/128/256/512 bit for intel/amd (and what about ARM, it works on ARM too) so could be 12 versions already"

Gator96100 commented 7 years ago

It would be possible to move march=x86-64 into "ifneq (,$(findstring MINGW,$(platform)))" and have march=native in the other conditions. I think it is safe to assume that most Windows machines support the x86-64 architecture.

iceman1001 commented 7 years ago

Great suggestion. Do it and I'll merge it

On 23 Apr 2017, at 12:27, Gator96100 notifications@github.com wrote:

It would be possible to move march=x86-64 into "ifneq (,$(findstring MINGW,$(platform)))" and have march=native in the other conditions. I think it is safe to assume that most Windows machines support the x86-64 architecture.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

iceman1001 commented 7 years ago

Thanks!