search

iceman1001 / proxmark3

[Deprecated] Iceman Fork, the most totally wicked fork around if you are into proxmark3
http://www.icedev.se/pm3.aspx
GNU General Public License v2.0
465 stars 116 forks source link

Check for Guardall/Verex seems to use much more bits than the clone command #104

Open ntkntk opened 7 years ago

ntkntk commented 7 years ago

Guardall's FCC is 8bits (or 256 max). for card number can only be 16bits (or 65535 max) as shown in https://github.com/iceman1001/proxmark3/blob/master/client/cmdlfguard.c#L165

The output shows the truncated 8b, 16b numbers used. However the check for Guardall seems to use much more bits than the clone command. Until the command "lf guard clone" is fixed to accommodate 32, 36 and 40bit types, Proxmark user should use "lf search" to get raw data then use t55xx write to create the Guardall 30-, 32- or 40bit

iceman1001 commented 7 years ago

The title is missleading. The functionality for lf guard clone has support for wiegand 26/32/36/40 and all other format length entered becomes 26 format. These different formats is not properly tested against a valid reader. GetGuardBits() function as commented in the source code currently work for wiegand26. I suppose this is the bug you want to report.

If you have correct conversions for 32/36/40 guardall wiegand format, do please contribute them. otherwise the quick fix would be to limit format length input to the clone command.