Closed micolous closed 6 years ago
Strange that the iProduct string has anything to do with the identification, I only thought it was the iManufacturer string which was matched. Dunno why you change serialnumber, I thought it had to be a numberstring (not with letters inside)
iManufacturer
is the only thing that is used for the udev rules (on Linux). I use the USB device ID for Android stuff, because some versions of Android don't have the strings easily available :(
iProduct
is not used by anything, and I don't match it by anything. However, there are strange enumeration issues with some Android devices (per the upstream PR). This cleans that up.
iSerialNumber
was more a "while I'm here..." thing. It doesn't get set by the upstream PM3 firmware. I don't see any strict requirements on what it is (ie: must be a number), other than it being "manufacturer determined". Happy to drop that if it bothers you greatly, as it's not critical. It's just a little more meaningful than "888".
Drop the "1001" part of the iSerialNumber and I'll be happy to merge.
TeamWalrus was doing something similar, luckily you changed the iSeralnumber :) https://github.com/TeamWalrus/proxmark3/commit/1be25f9125385ffff958450fd8461a435e49001f
Done. I also note @cjbrigato's comments in https://github.com/RfidResearchGroup/proxmark3/commit/ff16cbb4dba558909fc72494b1e351ac73ea5626#commitcomment-30407117
That is, the device path will change between the bootrom and flasher on OSX, and one will need to flash the bootrom before the flasher.
I will revert back to the 888 ish after this one, but making sure it is not a % 8 tuple
This is a port of upstream PR 565, which addresses USB enumeration issues on some Android devices, described in https://github.com/Proxmark/proxmark3/pull/565#issuecomment-366430026. Still don't know why this is a problem, but this patch seems to fix things.
I also took the liberty of changing the serial number of the device to
iceman1001
, which should make it pretty obvious indmesg
and similar tools when someone is running this firmware: