search

iceman1001 / proxmark3

[Deprecated] Iceman Fork, the most totally wicked fork around if you are into proxmark3
http://www.icedev.se/pm3.aspx
GNU General Public License v2.0
466 stars 116 forks source link

Add -fPIC #291

Closed phcoder closed 5 years ago

phcoder commented 5 years ago

It's required to compile on aarch64 and doesn't hurt on other platforms

iceman1001 commented 5 years ago

This one isn't that easy. there was issues with QT, see client/Makefile. for -fpic, and cross compiling.

phcoder commented 5 years ago

NVM for -fPIC, turns out setting it in environment variable is good enough. A different question: why do we include -ltermcap ? Termux has no libtermcap and if I remove -ltermcap and add -fPIC to environment variables it compiles and work nice (through tcp-serial proxy)

iceman1001 commented 5 years ago

Think Mingw, WSL, *nix, OSX, Android and that the project does compile on those. So before getting ideas of removing stuff, stop and think "I wonder if this change would break compilation on a different platform?"...

iceman1001 commented 5 years ago

Head over to RRG/Iceman repo and see what we can do with your suggestions over there.