icenet-ai / icenet

The icenet library is a pip installable python package containing the commands and code you need to produce forecasts
MIT License
21 stars 7 forks source link

Update metric computation to work with lat/lon region bounds #283

Open bnubald opened 3 months ago

bnubald commented 3 months ago

Description

Please see details in #282 pull request.

In short, as of this post, forecast output generation (png, mp4) works with lat/lon region definition, but metrics generation such as sie, binary accuracy, etc within icenet/plotting/forecast.py needs changes to Mask class to allow bounding the mask output (e.g. active cell mask). Currently this is not done, hence the metric outputs will be incorrect if defining a region based on lat/lon.

bnubald commented 3 months ago

In meantime, these metric plots should not be output to avoid confusing user!

bnubald commented 3 months ago

In meantime, these metric plots should not be output to avoid confusing user!

Resolved by latest commit above.