search

icerockdev / moko-geo

Geolocation access for mobile (android & ios) Kotlin Multiplatform development
https://moko.icerock.dev/
Apache License 2.0
176 stars 16 forks source link

Allow coarse location #38

Open janbina opened 1 year ago

janbina commented 1 year ago

Hi guys, firstly, thanks for this library, it's very helpful for me!

However, one thing that was bothering me is that you always ask for Permission.LOCATION and there is no ability to work with coarse location.

This is especially bad since on newer android versions, user is always presented with an option to only allow coarse location. This could lead to a scenario when you call startTracking, user selects coarse location, thinking location features will start working, but they won't. And only next time you call startTracking, user is presented with another dialog to change location access from approximate to precise.

I've added an option to allowCoarseLocation with default value false, so it should be a non-breaking change. However, I really believe that true should be the default in the future, because of the aforementioned behavior.

Douvi commented 1 year ago

Hey @janbina, I like your change. Do you know when it will be merged?

swapnil-musale commented 11 months ago

Hey @Alex009, Do you have any plan to push this change on the master in near future?