search

icerockdev / moko-mvvm

Model-View-ViewModel architecture components for mobile (android & ios) Kotlin Multiplatform development
https://moko.icerock.dev/
Apache License 2.0
1.02k stars 95 forks source link

Removed unnecessary dependency on appcompat library #210

Closed leisuresuit closed 1 year ago

leisuresuit commented 1 year ago

Problem Statement With a dependency on appCompat, dependencies from androidx.appcompat:appcompat are packaged in the application. This unnecessarily increases the app size (especially for an app that uses only Jetpack Compose). (Because this is a transitive dependency, it's impossible for an app to remove the appcompat classes using proguard/R8).

Solution mvvm-core requires only the lifecycle library. Therefore, replace appCompat with lifecycleKts.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information