Closed GabrielNoam closed 2 years ago
hi! can you check please versions of environment:
also show please how you configure dependency?
Hello. Sorry for the late reply. First, I've continued to work on migrating project from moko-mvvm-0.6.0 to moko-mvvm-0.3.1 and finally succeeded :) I am using: distributionUrl=https\:// services.gradle.org/distributions/gradle-5.6.4-all.zip
In app gradle dependencies: implementation("dev.icerock.moko:mvvm:$moko_mvvm_version") In shared module dependencies: sourceSets { commonMain.dependencies { api 'org.jetbrains.kotlin:kotlin-stdlib-common' // MOKO - MVVM implementation "dev.icerock.moko:mvvm:$moko_mvvm_version" .... } .... }
The problem with old project that did not compile was that there was a mixture of versions https://drive.google.com/file/d/1Iq8IxXFnnnZE-Kpgb9xgbIMcmMvfLDqG/view?usp=sharing
I think issue can be closed. Thank you for all your efforts and dedication to assist.
On Tue, Mar 24, 2020 at 3:02 PM Aleksey Mikhailov notifications@github.com wrote:
hi! can you check please versions of environment:
- kotlin 1.3.70
- gradle 5.6.4+
also show please how you configure dependency?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/icerockdev/moko-mvvm/issues/41#issuecomment-603225222, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKX2HLU32AVOKTZQWW2KWTRJCVPLANCNFSM4LSINYDA .
What was the issue exactly and what changes did you make to solve it? I have the exact same error message trying to use moko mvvm on my multiplatform project created from scratch using the kotlinlang mpp tutorial.
root build.gradle : https://github.com/alan-camilo/paris-respire-app/blob/icerockmvvm/android/build.gradle.kts mpp-module build.gradle.kts : https://github.com/alan-camilo/paris-respire-app/blob/icerockmvvm/module-mpp/build.gradle.kts android app build.gradle.kts : https://github.com/alan-camilo/paris-respire-app/blob/icerockmvvm/android/app/build.gradle.kts
TLDR; kotlin version 1.3.70 gradle version 6.2.2 moko mvvm 0.6.0 settings.gradle has enableFeaturePreview("GRADLE_METADATA")
Dear Alan, I've cloned your project in order to fix it and was unable to build: paris-respire-app output ... not found. Anycase I've updated Javier Arroyo jarroyoesp@gmail.com code example with moko 0.6.0 but couldn't make a pull request :( Therefore, please download the project from this link for now: https://drive.google.com/open?id=1_T0atDRW-jLbkMH1QAaLvcW7xN3yxjDp
Make sure you are using Android Studio 3.6 RC 3
Hope this helps. Best, Gabriel
On Fri, Apr 3, 2020 at 5:22 AM Camilo H_ notifications@github.com wrote:
What was the issue exactly and what changes did you make to solve the issue? I have the exact same one trying to use moko mvvm on my multiplatform project created from scratch using kotlinlang tutorial.
root build.gradle : https://github.com/alan-camilo/paris-respire-app/blob/icerockmvvm/android/build.gradle.kts mpp-module build.gradle.kts : https://github.com/alan-camilo/paris-respire-app/blob/icerockmvvm/module-mpp/build.gradle.kts
TLDR; kotlin version 1.3.70 gradle version 6.2.2 settings.gradle has enableFeaturePreview("GRADLE_METADATA")
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/icerockdev/moko-mvvm/issues/41#issuecomment-608193274, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKX2HOY3FHC2MEEZGIL5QLRKVB5VANCNFSM4LSINYDA .
@GabrielNoam thx for uploading your project, it helped me to understand my mistake.
My multiplatform module (module-mpp) was a jvm lib, I migrate it to an android lib. Now the build.gradle.kts of the module-mpp looks like this: https://github.com/alan-camilo/paris-respire-app/blob/dev/module-mpp/build.gradle.kts
You can note that in the kotlin section, the target set-up went from
jvm("android")
to
targets {
targetFromPreset(presets.getByName("android"), "android")
}
It now compiles without error.
Greate :) Thanks
On Sun, Apr 5, 2020 at 6:43 PM Camilo H_ notifications@github.com wrote:
@GabrielNoam https://github.com/GabrielNoam thx for uploading your project, it helped me to understand my mistake.
My multiplatform module (module-mpp) was a jvm lib, I migrate it to an android lib. Now the build.gradle.kts of the module-mpp looks like this: https://github.com/alan-camilo/paris-respire-app/blob/dev/module-mpp/build.gradle.kts
You can note that in the kotlin section, the target set-up went from
jvm("android")
to
targets { targetFromPreset(presets.getByName("android"), "android") }
It now compiles without error.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/icerockdev/moko-mvvm/issues/41#issuecomment-609436707, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKX2HINMNEWQFHNFTXLYMDRLCRINANCNFSM4LSINYDA .
I am combining it into my project after follow basic guidelines for building multi-project using: https://proandroiddev.com/kotlin-multiplatform-very-beginners-guide-part-1-6419f74afa0f https://proandroiddev.com/kotlin-multiplatform-very-beginners-guide-part-2-api-d54f7326dc57 I run into strange error of "Unable to find a matching variant of dev.icerock.moko:mvvm:0.6.0" (see below gradle output) thaw I am doing the exact steps in https://github.com/icerockdev/moko-mvvm README
I've added my project gradle files (app and shared) to share location on my Google drive: https://drive.google.com/file/d/1Iq8IxXFnnnZE-Kpgb9xgbIMcmMvfLDqG/view?usp=sharing
Thank you in advance for the great work.
Best regards, Gabriel