icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.
https://docs.icerpc.dev
Apache License 2.0
107 stars 13 forks source link

Rename IceRpc.Builder => IceRpc.Extensions.DependencyInjection #3123

Closed bernardnormier closed 1 year ago

bernardnormier commented 1 year ago

With #3117, we need 3 namespaces when using DI:

In #3122, Jose moved most (but not all) IInvokerBuilder and IDispatcherBuilder extension methods from IceRpc.Builder to IceRpc.Extensions.DependencyInjection. That's fine but it doesn't go far enough. We don't need this IceRpc.Builder namespace: IInvokerBuilder and IDispatcherBuilder should go into IceRpc.Extensions.DependencyInjection.

With this setup:

This could be slightly confusing but I think that's fine. It's all about DI.

pepone commented 1 year ago

Where will you put src/IceRpc/Builder/*.cs files, src/IceRpc?

bernardnormier commented 1 year ago

in src/IceRpc/Extensions/DependencyInjection

pepone commented 1 year ago

Fixed in #3122