Add Slice.Tests.Common - Githubissues

icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.

https://docs.icerpc.dev

Apache License 2.0

107 stars 13 forks source link

Closed pepone closed 1 year ago

pepone commented 1 year ago

          IceRpc.Tests.Common = common test-related public classes with a dependency on IceRpc

We could add: Slice.Tests.Common = common test-related public classes with a dependendency on Slice

and use Slice.Tests.Common in Slice tests and in IceRpc.Slice tests.

pepone commented 1 year ago

For Slice.Tests I copied two types from IceRpc.Tets.Common TestMemoryPool and MemoryBufferWriter

I wouldn't add a new assembly:

We want to eventually move Slice to a separate repository, and I think we should minimize the dependencies for the tests, as they wouldn't be as stable as the release assemblies
These test assemblies have to be public because of IceRpc.Conformance.Tests, which already depend on IceRpc.Tets.Common

bernardnormier commented 1 year ago