search

icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.
https://docs.icerpc.dev
Apache License 2.0
107 stars 13 forks source link

Rename ProtobufOperationAttribute to ProtobufMethodAttribute #3741

Closed pepone closed 1 year ago

pepone commented 1 year ago

In Protobuf, operations are typically referred to as 'methods'. Therefore, it might be logical to use ProtobufMethodAttribute as the attribute name

bernardnormier commented 1 year ago

I agree.

ProtobufOperationAttribute is not incorrect since it's about specifying the operation in the icerpc / ice request header.

However, this operation must be the Protobuf rpc method name - that's an essential part of the Protobuf contract. And if you're using Protobuf as your IDL, you should be insulated from low-level details like the exact names used in icerpc request headers.