This PR adds more comprehensive testing for custom types in Slice1 contexts and fixes #3918,
which caused slicec-cs to treat tagged custom types as optional (untagged) custom types.
The only way to test this was with classes (the only Slice1 type that can hold tags).
But, this means the class encoding bleeds into what should be a test purely for custom types.
Maybe this is just how it is, but if anyone has any ideas to avoid this, they'd be welcome!
This PR adds more comprehensive testing for custom types in Slice1 contexts and fixes #3918, which caused
slicec-cs
to treat tagged custom types as optional (untagged) custom types.The only way to test this was with classes (the only Slice1 type that can hold tags). But, this means the class encoding bleeds into what should be a test purely for custom types. Maybe this is just how it is, but if anyone has any ideas to avoid this, they'd be welcome!