icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.
https://docs.icerpc.dev
Apache License 2.0
101 stars 13 forks source link

Re-evaluate our usage of `str`, `String`, etc. in `slicec-cs` API #3926

Closed InsertCreativityHere closed 3 months ago

InsertCreativityHere commented 6 months ago

We have a variety of function signatures ranging from simple &str to T: ToString to impl Into<String>. We should look through our API surface and see if these types could be improved (for greater flexibility on the calling side), or simplified in cases where it's use is limited.

See https://github.com/icerpc/icerpc-csharp/pull/3925#discussion_r1487969037

InsertCreativityHere commented 3 months ago

The distinction between str and String is specific to Rust. Since the eventual goal is to port slicec-cs to C# (#3978), there's no point in these Rust-specific improvements.