search

icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.
https://docs.icerpc.dev
Apache License 2.0
101 stars 13 forks source link

Include arm64 protoc with our IceRpc.Protobuf.Tools #3966

Closed pepone closed 5 months ago

pepone commented 5 months ago

For macOS you can use Rosseta, but as @ReeceHumphreys found out if you are using a dev container on macOS, the provided Linux image is arm64 and the protoc compiler is not available.

The IceRpc.Protobuf.Tools NuGet package repackages the protoc binaries from the Google.Protobuf.Tools NuGet package; however, it lacks arm64 binaries.

We can upgrade the IceRpc.Protobuf.Tools NuGet package to download the binaries from the Google.Protobuf.Tools release page: https://github.com/protocolbuffers/protobuf/releases

bernardnormier commented 5 months ago

Once this done, please remember to remove "3" in the Prerequesites: https://github.com/icerpc/icerpc-csharp/blob/main/BUILDING.md#prerequisites

bernardnormier commented 5 months ago

Also update the bottom of https://github.com/icerpc/icerpc-csharp/blob/main/tools/IceRpc.Protobuf.Tools/README.md

ReeceHumphreys commented 5 months ago

Closed by #3969