icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.
https://docs.icerpc.dev
Apache License 2.0
94 stars 13 forks source link

Format XML with prettier #4007

Closed ReeceHumphreys closed 1 month ago

ReeceHumphreys commented 1 month ago

After looking at a few different XML parsers, I think this integration from prettier seems to be the best.

bernardnormier commented 1 month ago

It would be good to open the projects with Visual Studio (not VS code) to make sure VS does not immediately reformat all the project files.

ReeceHumphreys commented 1 month ago

@bernardnormier Just opened the IceRpc.sln on my mac with visual studio and nothing changed! I have 0 familiarity with Visual Studio so im not sure if this is sufficient to show that the formatting is preserved. @pepone could you verify if Visual Studio leaves the files with the new formatting?

pepone commented 1 month ago

could you verify if Visual Studio leaves the files with the new formatting?

Yes, formatting remains the same after opening the solution in Visual Studio 2022 on Windows.