search

icerpc / icerpc-csharp

A C# RPC framework built for QUIC, with bidirectional streaming, first-class async/await, and Protobuf support.
https://docs.icerpc.dev
Apache License 2.0
102 stars 13 forks source link

Rename property to enable/disable build telemetry #4033

Closed bernardnormier closed 2 weeks ago

bernardnormier commented 2 weeks ago

This PR renames two build telemetry properties:

Fixes #4015

InsertCreativityHere commented 2 weeks ago

I still believe in my previous position, but I also think that the difference in understandability is near-negligible. So: "looks good!"

Personally, I prefer the current name. Having it be a 'negative' phrase It makes it very clear that this is opt-out, and that by default, we're sending build telemetry. Whereas naming it something positive (IMO) implicitly makes it seem more like it's opt-in. At least without having to go read some defaults somewhere.