search

icerpc / slicec

The Slice compiler library
Apache License 2.0
13 stars 5 forks source link

Removed 'AST' from Validator Functions. #563

Closed InsertCreativityHere closed 1 year ago

InsertCreativityHere commented 1 year ago

This PR removes the 'ast' parameter from all of our validator functions, because it wasn't used anywhere. I'm opening this PR in case anyone knows why we have it: maybe we'll need it for some future validation? Or had that validation, but it got deleted somewhere along the refactoring?

It's probably just an oddity from our Validator setup, but figured I'd ask to make sure : v)

PS: sorry if this steps on anyone's toes. This was originally part of my PR for removing doc comments from params and modules, but I split it off to avoid merge conflicts.

externl commented 1 year ago

We had it for validating / patching doc comments. I think you removed this when doc comments were refactored.