Change when we suggest "you may want to use Slice1"

icerpc / slicec

The Slice compiler library

Apache License 2.0

13 stars 5 forks source link

Change when we suggest "you may want to use Slice1" #576

Closed externl closed 1 year ago

externl commented 1 year ago

I think we should suggest "you may want to use Slice1" only when:

the user defines a class in a Slice2 file
the user references a Slice1-only construct from a Slice2 file (class or other constructed type that is Slice1-only for some reason)

Originally posted by @bernardnormier in https://github.com/icerpc/slicec/pull/575#pullrequestreview-1434790745

externl commented 1 year ago

We never actually suggest switching the encoding to slice1, we just had a a note explaining how to set it if you were using the default. #580 removes this as it was a little confusing.

I don't think we should suggest changing the encoding. We don't know what else is in the file, I don't think there's a good and reasonable suggestion to make.