icerpc / slicec

The Slice compiler library
Apache License 2.0
13 stars 5 forks source link

Remove Note Indentation #654

Closed InsertCreativityHere closed 1 year ago

InsertCreativityHere commented 1 year ago

This fixes #626, where notes are weirdly indented sometimes. Now we just don't indent notes, they sit at the start of a line, same as warnings and errors. I think this is the simplest fix.

New note appearance

image image

InsertCreativityHere commented 1 year ago

Ignore the build failure, it's something else.

externl commented 1 year ago

Ignore the build failure, it's something else.

That should be fixed before you merge?

InsertCreativityHere commented 1 year ago

That should be fixed before you merge?

Yes, the failure is a test that was removed in: #653