search

ices-eg / DIG

ICES Data and Information Group
Creative Commons Zero v1.0 Universal
3 stars 1 forks source link

Backwards approval - more codes for BroadHabitat (VMS) #643

Closed pcrjoana closed 4 months ago

pcrjoana commented 4 months ago

Since the list on MSFD broad habitats was incomplete, I added those missing. They aren't on any online list, but they've been being used by EMODnet. Unfortunately it's an external list, so I had to use the codes as they are. https://vocab.ices.dk/?codetypeguid=be2bb421-f201-4bf3-a887-179b3dfbaac4

roimartins commented 4 months ago

Hi Joana , I sent a mail to EIONET helpdesk to highlight this mistmatch between their vocabulary list and the classes in the EMODNET EU SeaMap 2023 product .

However since these classes are present in the data and SFD experts consider relevant retain this information as it is , in SFD GOV we decided to include them in the ICES vocab list ( as matter of urgent fix to release datacall asap , but this coudl be reviewed in SFD WG meeting) .

Also it brings an interesting question , what happens when a field needs to include 2 classes listed in the vocabulary ( e.g. due to uncertainty on what class to assign ) . I would guess the best is not create combinations of key labels in one field but spread across two fields. Otherwise you could end with infinite list of combinations and vocabulary classes .

pcrjoana commented 4 months ago

That's perfect Roi! I've added the codes to the vocabulary and they'll be available online tomorrow. It is an interesting question. Currently we're creating the combination of codes, as it's easier from a format standpoint (i.e how many extra fields would we need? It can greatly depend between datasets). The only unfortunate thing with this vocab is how long the codes, specially the combined ones, are. This is however not an ICES list, so we keep the codes as they are. :-)

pcrjoana commented 4 months ago

@pcrjoana to link BroadHabitat to the corresponding external vocab.