search

ices-eg / DIG

ICES Data and Information Group
Creative Commons Zero v1.0 Universal
3 stars 1 forks source link

ShinyApp: NEAFC Catch Explorer #692

Open neil-ices-dk opened 1 month ago

neil-ices-dk commented 1 month ago

Checklist against https://doi.org/10.17895/ices.pub.22695898.v1

Step 1 licensing

App is open, and data are anonymised: complies with CC BY 4.0 Code has CC0 license https://github.com/ices-tools-prod/NEAFC_Spatial_Catch_Explorer

Step 2 Data Profile

Initial profiling done, which sparked the process to bring up to standard described in ShinyApp guidance

Step 3 Ownership

Defined in Meta data record 2 year product (maximum allowed) no dependencies

Step 4 ACOM approval

This app is part of the advice request: ICES (2024). NEAFC request on discarding in the NEAFC regulatory areas. ICES Advice: Special Requests. Report. https://doi.org/10.17895/ices.advice.26947132.v1

Post approval: Step 1 code published

Published https://github.com/ices-tools-prod/NEAFC_Spatial_Catch_Explorer

Post approval: Step 2 metadata

drafted, needs a small adjustment @colinpmillar and then can be pushed to Periklis for approval

Post approval: Step 3 ICES website anchor

https://www.ices.dk/advice/NEAFC-catch-explorer/Pages/NEAFC%20catch%20explorer.aspx

Post approval: Step 4 test and review

@colinpmillar has reviewed the code and tested @neilcampbelll to change the 3 species codes to descriptive names/reference vocab @neilcampbelll to add link back from app (https://ices-taf.shinyapps.io/neafc-catch-explorer/) to the landing page on ICES sharepoint website https://www.ices.dk/advice/NEAFC-catch-explorer/Pages/NEAFC%20catch%20explorer.aspx

neil-ices-dk commented 1 month ago

@neilcampbelll are the loose ends addressed, can you confirm and close ticket if all is squared away - thanks

neil-ices-dk commented 1 month ago

@neilcampbelll the species codes need updating still; btw - is this working? image

neil-ices-dk commented 1 month ago

@neilcampbelll i've discussed with @colinpmillar and we agree that you need a pop-up prompting users to zoom as it is not intuitive that there are no data points rendered and you have to guess where to zoom to see the rendering of data

neilcampbelll commented 4 weeks ago

Thanks Neil - will speak to @colinpmillar when I am back in the office and make these changes next week

neilcampbelll commented 3 weeks ago

image

Changes proposed by @neil-ices-dk implemented.

@colinpmillar do you need to work some magic at your end?

neilcampbelll commented 3 weeks ago

image

neil-ices-dk commented 3 weeks ago

i love it when a plan comes together, nice work both

neil-ices-dk commented 1 week ago

@neilcampbelll @colinpmillar the Geonetwork meta data record is not published nor linked to the landing page. Is the meta data record complete and up-to-date?

draft record: https://gis.ices.dk/geonetwork/srv/eng/catalog.search#/metadata/902070c1-eec2-49fc-8b82-23f1afc5a788

Can you check and inform @PeriklisICES if it can be published, thanks

colinpmillar commented 1 week ago

[like] Colin Millar reacted to your message:

From: Neil Holdsworth @.> Sent: Monday, November 11, 2024 12:42:26 PM To: ices-eg/DIG @.> Cc: Colin Millar @.>; Mention @.> Subject: Re: [ices-eg/DIG] ShinyApp: NEAFC Catch Explorer (Issue #692)

@neilcampbelllhttps://github.com/neilcampbelll @colinpmillarhttps://github.com/colinpmillar the Geonetwork meta data record is not published nor linked to the landing page. Is the meta data record complete and up-to-date?

Can you check and inform @PeriklisICEShttps://github.com/PeriklisICES if it can be published, thanks

— Reply to this email directly, view it on GitHubhttps://github.com/ices-eg/DIG/issues/692#issuecomment-2468089479, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALO5AE2Y3VADCC6V6PV65L2ACQ3FAVCNFSM6AAAAABPULNZM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRYGA4DSNBXHE. You are receiving this because you were mentioned.Message ID: @.***>