search

ices-eg / RCGs

A place for the Regional Coordination Groups (RCGs) to store scripts (e.g. for map-plotting, age-length relationships) to make them available to other groups and improve the development and exchange.
7 stars 8 forks source link

target_region not defined #174

Closed mrska closed 5 months ago

mrska commented 5 months ago

instead of target region it should be regionSelected. filename_vector corrected

mrska commented 5 months ago

And here I have the same suggestion as in the #172 It might be a bit complicated for a user to go through several scripts to set up the proper parameters.

download_data_from_sharepoint(
    sharepoint_address = "Path to SharePoint",
    filename_vector = paste0('RCG_',regionSelected, ".zip"), 
    dir_download_browser = "Path to directory where browser downloads",
    dir_download_target = "Path to directory where data should be stored",  
    unzip=TRUE
  )

In this case, I think the parameters which not be calculated from the other setups, should be moved into the main annual_overview_RDBES.R. So that a user has just one place to define all the necessary parameters

erosquesada commented 5 months ago

Good point, we thus shall add to the main annual_overview_RDBES.R the parameters values for the uncommented arguments of the download_data_from_sharepoint function below. Depending on what is decided about the SP structure (see discussion in #172, in case the data has one fixed location on SharePoint for multiple years), the "sharepoint_adress" may be always the same and does not need to enter the annual_overview_RDBES.R. 

download_data_from_sharepoint(
    sharepoint_address = "Path to SharePoint",
    # filename_vector = paste0('RCG_',regionSelected, ".zip"), 
    dir_download_browser = "Path to directory where browser downloads",
    dir_download_target = "Path to directory where data should be stored", 
    # unzip=TRUE
  )