ices-eg / SmartDots

SmartDots is the otolith reading software developed by ILVO that ICES is collaborating on
GNU General Public License v3.0
9 stars 2 forks source link

Develop a SmartDots disclaimer #41

Closed cmspinto closed 2 years ago

cmspinto commented 6 years ago

We need a disclaimer for smartdots to come when people make the download of data.

JCoadDavies commented 5 years ago

there is an ICES data policy pdf included in the download data zip file. Is this sufficient??

cmspinto commented 5 years ago

A template for the disclaimer Smartdots_Disclamer_draft.docx :.

kbekaert commented 4 years ago

Need to check with Loes and Rui what's the status of this.

JCoadDavies commented 4 years ago

Smartdots_Disclamer_draft_loes.docx Smartdots_Disclamer_draft.docx Disclaimer_Exchange Data_2019-09-23 09_57_56.txt

Files above provided by Loes at WGBIOP 2019 and requested review by ICES & software-people...

JCoadDavies commented 4 years ago

missing feedback from @neil-ices-dk @Rui-Catarino

neil-ices-dk commented 4 years ago

will take a look this week :)

neil-ices-dk commented 4 years ago

ok, i am currently reviewing the generic ICES data disclaimer that the templates you are using are based on. So i can foresee some changes once this is completed. I'm just awaiting feedback and then we can take a look together - it's not massively different but more updated and consolidated. One issue is that we collect IP addresses, which are considered under GDPR.

neil-ices-dk commented 4 years ago

ICES Generic disclaimer review_v3.docx @JCoadDavies @kbekaert ladies - back to you - this is the 'new' version of the ICES generic disclaimer that we will use on all data portals - there is a section that is specific to the portal in question, and i guess where it will need your SmartDots eyes on.

JCoadDavies commented 4 years ago

ICES.Generic.disclaimer.review_v3_SmartDots.docx

Hi! I have taken part of what Loes had initially written for the first disclaimer and adapted it. @neil-ices-dk Do we need to add more?

neil-ices-dk commented 4 years ago

Thanks Julie, will take a look and get back to you 👍

neil-ices-dk commented 4 years ago

Couple of comments back:

neil-ices-dk commented 4 years ago

i forgot this one, you had a question about DATSU, there is something there for SMARTDOTs but check with Carlos https://datsu.ices.dk/web/rptChk.aspx?Dataset=129

JCoadDavies commented 4 years ago

Thanks Neil. Updated now with 2 questions:

  1. LAYERNAMEXXX, requested from www.xxxxxxxxxxxxxxxxxxx on DATETIMEXXX - Does this remain like this and then xx's filled in automatically at time of download?

  2. @cmspinto can you please help with the comment on the data format, see comment in the file.

ICES.Generic.disclaimer.review_v3_SmartDots.docx

neil-ices-dk commented 4 years ago

LAYERNAMEXXX, requested from www.xxxxxxxxxxxxxxxxxxx on DATETIMEXXX - Does this remain like this and then xx's filled in automatically at time of download?

Yes - this is automated :)

JCoadDavies commented 4 years ago

ICES.Generic.disclaimer.review_v3_SmartDots.docx

@cmspinto Carlos can you please check the comment for you. This is the final version

cmspinto commented 4 years ago

ICES.Generic.disclaimer.review_v4_SmartDots.docx

Have review the disclamer, this is aplicable for the public events and the download is suppose to be the source of the R script.

Currently it only has three files: image

But in future the disclamer will come in the download.

JCoadDavies commented 4 years ago

ICES.Generic.disclaimer.review_v4_SmartDots.docx

I checked the links in the document and they are not working anymore, I assume this is after the ICES webpage has been updated. Can you please help. There is also a comment on the Contact Info and Data Specific Information.

cmspinto commented 4 years ago

Thanks for the heads up.

Corrected the links in the document

ICES.Generic.disclaimer.review_v5_SmartDots.docx

JCoadDavies commented 4 years ago

Thanks Carlos

@neil-ices-dk Hi Neil, this should be final and ready.

ICES.Generic.disclaimer.SmartDots.docx

neil-ices-dk commented 4 years ago

@JCoadDavies and @cmspinto looks good - one small addition. In the 'Data specific section' you could add (part in bold):

All source code is publicly accessible and under the terms of a General Public License (https://github.com/ices-eg/SmartDots/blob/master/LICENSE)

JCoadDavies commented 4 years ago

Done ICES.Generic.disclaimer.SmartDots.docx @neil-ices-dk @cmspinto i guess this is now up to you to make it available with the report and data download

cmspinto commented 4 years ago

Disclamer is not part of the download.

image

@JCoadDavies, @JaneGodiksen need to check the part of acknowledge data source.

JCoadDavies commented 4 years ago

Sorry, I am a little confused...the Disclaimer is part of the download, I just downloaded and it is there. So i don't see what needs to be checked. Can you be more specific @cmspinto

neil-ices-dk commented 4 years ago

Disclamer is not part of the download.

image

@JCoadDavies, @JaneGodiksen need to check the part of acknowledge data source.

while you are at it, could you change the spelling of the file to 'disclaimer.txt' thanks :)