ices-eg / SmartDots

SmartDots is the otolith reading software developed by ILVO that ICES is collaborating on
GNU General Public License v3.0
9 stars 2 forks source link

2 extra properties: Nucleus IsOpaque & Edge IsOpaque #76

Open wimallegaert opened 6 years ago

wimallegaert commented 6 years ago

For herring, the distinction between autumn/winter spawners and spring spawners is done based on the structure of the nucleus (opaque or translucent). We would like to ask for an additional data field to be able to fill in this observation. That would be an extra field in the screen that pops up after the annotation is completed. A non-obligatory field because it is only relevant for herring.

Suggested by Loes Bolle

2 extra properties (boolean) per annotation needed:

wimallegaert commented 5 years ago

Estimation implementation effort ILVO: 8h

WMR suggested alternative implementation: develop functionality so that properties can be added dynamically to an annotation via the Web API. This solution will be for sure more future proof, in this case new future annotation properties could be added without changes to the software. Unfortunately this development is more complex.

wimallegaert commented 5 years ago

The following was agreed on WGSMART Meeting April 25th:

The options Opaque and Translucent for the NucleusState and the EdgeState will be displayed in a dropdown list / combo box control. This seems clearer to us than a checkbox.

kevinatilvo commented 5 years ago

It is now possible to let the software show 2 additional columns (Nucleus and Edge) in the Annotation panel. Extra functionality was added to the Web API to show or hide these properties per event. In the demo- environment the extra properties are shown in the Herring workshop (20170009).

image

In the annotation grid, the 2 extra columns are shown. You can manage the Edge and Nucleus properties directly in the grid. The available options for both properties are: Opaque, Translucent, NA (not applicable). The software will translate NA to null (nothing).

image

The Edge and Nucleus fields are also integrated in the popup window to edit/save the annotation.

image

cmspinto commented 5 years ago

when activating this extra properties they always go together or they should be activated separately?

So I guess that what I’m asking is if we do this:

1st scenario:

Enable Nucleolus property?

Enable Edge property?

2nd scenario:

Enable Nucleolus and Edge properties?

This option will be in the edit event page.

cmspinto commented 5 years ago

We go for the 1st scenario, Loes confirmed this in an email from the 9th of September.