Open John-Ball-Cefas opened 3 years ago
To identify style issues with the draft package, install the lintr package and then run _lintr::lint_package(linters=lintr::with_defaults(object_name_linter=lintr::object_namelinter(styles = "camelCase"))) This should identify the style issues that will be flagged when committing to the package.
The styler R package (using the tidyverse style) can be used to fix some common style problems easily (e.g. spaces after commas) - there is an RStudio add-in for this that allows you easily style a selection of code or a file. Once you do this you are left with the following issues:
I've put cleaned versions of the functions in the SG6 branch https://github.com/ices-eg/WK_RDBES/tree/SG6/WKRDB-EST2/subGroup6/icesRDBES/R
Hello,
I have pushed the current draft of two functions to my personnel folder in SG1 (John). DBEpreparedObj has an oxygen skeleton, however generateProbs_John does not as I believe Nuno may have also been working on the function and it may need to be merged somehow. DBEpreparedObj: takes raw objects and fills out probabilities based on generateProbs_John and produces .rdata files of objs
generateProbs_John: fills out probabilities based on method col
Cheers,
John