Closed cedricbriandgithub closed 4 years ago
Esti picked up a list of comments :
~~NOTE There is nothing in our sheets to enter data for the station table, for next year insert a sheet with fields
ref.tr_station( "tblCodeID",
"Station_Code",
"Country",--'country responsible of the data collection ?'
"Organisation",
"Station_Name",
"WLTYP",--'Water and land station types ';
"Lat",
"Lon",
"StartYear",
"EndYear",
"PURPM",'Purpose of monitoring http://vocab.ices.dk/?ref=1399'
Not a priority~~
* In the case of landings Should we add a column to say if there have been changes in effort (it would have been more practical to do that in a yearly basin, but… this might help to interpret trends)
* No landings since not pertinent. Since files with no value at all cannot be integrated, nothing was integrated. Note to self: How should this be dealt with? Additional note, this creates a problem with Ireland. Check why we cannot integrate in the app. If it's an enhancement to made, mark it so. => Fixed with hilaire function and asking for missing data
~~ * Aquaculture was not integrated since the database doesn't allow for sheets with no values at all. This should be adressed in general during WGEEL, we need to agree on a working practice concerning no data, 0 values etc.~~
CHECK Rules for integration were currently 10 years. I think we should allow for long time series to be included even if shorter than 10 years. Discuss that within wgeel.
THINGS TO CHECK BEFORE SUBMITTING THE DATA CALL
~~ Fill in all the columns. Excect from:
If in eel_hty_code you have included Freshwater, you should not include any information in area division
~~ In the releases file, if you choose GEE you should fill in the eel_value_number column and no kg estimate should be reported.~~
~~ If you think none of the codes fit your case, use the one that fits best and use the comment column to explain it, do not include combinationsof codes or invent new ones because they will give errors. ~~
~~ Use the codes exactly as they appear on the excel sheets (upper/lower case, dashes, etc...)~~
* If you have not included any value in the eel value column, you have to include one of the following options in the eel_missvaluequal column: NR not reported, NC not collected, NP not pertinent, or ND no data
* If aquaculture is solely for restocking this should not be reported in the aquaculture file
* In the releases file, Even though eel_typ_name asks for Numbers, fill in both eel_value_N and eel_value_KG columns
* eel_value" = "0" means for example that there is a fishery and the catches have been 0. Thus having “0” in eel value, NR not reported, NC not collected, NP not pertinent, or ND no data in "eel_missvaluequal" is wrong.
* Check you just have one value per year/emu/stage/ area/habitat.
shorten cover letter if possible~~Specify in cover letter/spreadsheet, that data should be reported either by EMU OR total YG is no longer an option in releases, check if thats in the scripts/database and edit spreadsheet accordingly~~
Add section to cover letter specifying that data call is NOT the same as havin no obligation to report under EU DCF Basically there are 3 levels of reported data: 1. Reported but totally incomplete (e.g. trap still fishing), 2. Data that is reported and complete but provisional (e.g. some last corrections were not applied), 3. Data that is complete (e.g. trapping has stopped, all corrections are applied). -> Only the latter two should be provided, decision made by the provider! Make this clear in the spreadsheet and cover letter - possibly also the spreadsheets. Make distinction in the chapter/tables.
Add/modify releases spreadsheet to ask for the proportion of eel stocked above barriers/hydropowercheck that qual_id, qual_comm, datasource have been removed from all sheets => WHY ?
Check that it is possible to enter the year => checked but check again
Update list of Series names in spreadsheets (i.e. include the New series)Extract data and highlight where an update in the series comment and location is need (or any other information) => HIGHLIGHTING MUST BE DONE ONCE THE SPRADSHEETS ARE READY