quick bug shiny 2021

[cedricbriandgithub]

• ~constraint for biometry => add reference to datasource~
• ~change slider to 2020~ => WONTFIX, the program uses the latest year in the database
• ~Check number of columns in updated data (when copying the number of columns becomes 12) when pasted we don't have the qal_id~
• TODO Next year we need to have 1 more column in the updated data (12 instead of 11)
• ~Updated says integrate xls_new where in should be xls_duplicates~
• ~Bug in data correction when trying to update fires a missing value "Error: no applicable method for 'filter' applied to an object of class "logical"~
• ~new series, structure metadata check remove comment and check if it's OK~
• ~new series, series info, the number of columns should be 20~
• ~updated biometry, says there is a missing id but the id is there~
• Don't allow for automatic updates on the server, otherwise risks to crash during wgeel

[jdpo]

• ~after uploading releases, check file for releases_DE produces the error "undefined columns selected"~

  • the reason behind that bug was that you had a missing column, but somehow the message was not very explicit ... took me ages to fix that one, now if you have the wrong number of columnyou will get an error. You did have the right number of column because somehow the app integrated an empty column after the end. realxl integrates column names ...11 in place of empty columns. This is fixed for release but might be usefull to fix elsewhere ....

• minor: uploading an empty file produces a huge list of errors - if simple, maybe just a single erroe "empty file"?

• ~minor: time series integration gives options glass/yellow/silver - doesn't match the data call sheet names, amybe change "glass" to "recruitment"~

• ~recruitment series produces several errors for recruitment_DE (some issues with the file fixed, but not in the SP): The structure of metadata has been changed 0.xlsx loading series number column wrong for t_series_ser, should have been 19 in file dataset , column , line <7>, value is wrong, possibly not entered yet loading new_biometry dataset , columns <bio_length,bio_weight,bio_age,bio_perc_female,bio_length_f,bio_weight_f,bio_age_f,bio_length_m,bio_weight_m,bio_age_m>, all missing line 1;2;3;4;5;6;7;8;9;10...~ OK Fixed already

• ~same for yellow series yellow_DE: The structure of metadata has been changed 0.xlsx loading series number column wrong for t_series_ser, should have been 19 in file dataset , column , line <1>, value <1> is wrong, possibly not entered yet loading new_biometry dataset , columns <bio_length,bio_weight,bio_age,bio_perc_female,bio_length_f,bio_weight_f,bio_age_f,bio_length_m,bio_weight_m,bio_age_m>, all missing line 1;2;3;4;5;6;7;8;9;10...~ same problem fixed

• Indeed in yellow series no value is entered in line 8 but it does not show up as an error. Should it? => not sure I get what you mean, if it's existing data, yes you can enter a null values in the series but I think in that case das_qal_id has to be zero. You should get a warning at integration however.

• ~for silver eel series_DE it gives the error "length(unique(rls$res$series$ser_cou_code)) == 1 is not TRUE" - but there is only a single country code in "series_info"~ => OK there was an "empty line" at the bottom, now the check removes NA value so should no longer fire an error. You get the warning about the empty line however so it's OK

[sozdilek]

~In FR releases: After uploading Releases File the errors are: number of column wrong should have been 10 in the file for FR: However, there are already 10 columns in the file.~ => fixed ~Icolumn , lines <8>, there should be a value in both column eel_value_number and eel_value_kg: There are no values but there is "NC" on the "eel_missvaluequal". Therefore, it seems true. column , lines <19>, there should be a value in both column eel_value_number and eel_value_kg: The new data includes only 11 lines. dataset , column , missing values line 1: There is no headings "eel area division" in new data.~ => fixed

[sozdilek]

In the Time series data integration of IR Annex 3 (silver eel), I think there is a problem in the heading of updated biometry. When I delete the first empty line, a problem is going on. 1 | dataset , column , missing values line 1 |   1 | dataset , column , missing values line 1 |   2 | dataset , column , missing values line 2 |   1 | dataset , column , missing values line 1 |   1 | dataset , column , missing values line 1

[sozdilek]

~In yellow eel series Annex 2: Error: object 'res' not found~

[sozdilek]

In yellow eel series Annex 2: Error: object 'res' not found

The error is the same both in NL and in IE data

[sozdilek]

~Mortality rates: Error: argument "namedataset" is missing, with no default~

fixed

[sozdilek]

Mortality rates: Error: argument "namedataset" is missing, with no default The problem is in IE data The integration of the Mortality rates of NL is working.

[sozdilek]

Annex 7: The error: release dataset , column , missing values line 1 However, there is no column as "eel area division" in release data

Annex6 IE data: the error is related to updated data, there is no error in new data. However, it seems in new data. dataset , column , missing values line 1;2;3;4;5;6;7;8;9;10... Annex 6: It is the same in NL data. The error is related to updated data. I think there is a problem in reading new_data