Closed gavinmacaulay closed 4 years ago
A note: the proposed way to store backscatter power and split-aperture phase angles uses much more space than the same data in the EK60 .raw format. This needs to addressed (perhaps by supporting the compressed form of data that the EK60 .raw format uses).
Hi Gavin, please fin below a first set of comments from our Ifremer's side. (we will make detailled comments field by field once we agree on those ones)
You use the term sector to define the sub beams of the split beam, this could lead to some ambiguities with the kongbserg's sector definition used in bathymetry (which is a transmit_beam). We had thought of using the terms "element" or "quadrant" instead but no one is really good either. Do you have any idea ?
For the Sonar Beam coordinate system, I add difficulties to understand (might be my poor english). Maybe it could be better to split and add a new chapter "Inner beam coordinate system" to define the split aperture echo arrival angles.
Furthermore, I'm not sure I really understand the sentence : "If compensated, the sonar beam coordinate system is taken to be relative to the platform coordinate system prior to the effect of any pitch and roll of the platform". I'm getting confused with the Coordinates systems, what do you think of adding some maths in this chapter, I think it would be clearer to have some rotation matrix with both cases compensated/uncompensated. To be honest I think is missing somewhere the transducer installation rotations angles, the beam are pointed with reference to an array coordinate system and this one is not always strictly parallel to the platform coordinate system.
What do you think of renaming "rx_beam_rotation_alpha" to "rx_beam_rotation_z" ? People would only have to remember the figure with the axis positions, not the name of the associated angles.
We need to change tx_beam_direction_x to tx_beam_rotation_alpha or tx_beam_rotation_z to be consistent
Two remarks aside :
I am starting to be confused with the notion of major and minor angles, sometimes referred as Horizontal and Vertical, this is not clear to me. I would like to make a new pull request after this one for suggestions about clarifying those fields and discuss about this specific matter.
We will make later another pull request to rename the transmit_duration_equivalent variable to received_duration_equivalent, that should be the one used in the equations
For the minor and major angles, I chose two words that deliberately did not convey a particular direction (and are the words used by Echoview). For example, alongship and athwart don't quite work if a beam is pointing horizontally; horizontal and vertical confuse when a beam is pointing directly down; x&y would cause confusion with the platform coordinate system.
minor and major are good naming, better than along, athwart, vertical and horizontal. I will try to make a drawing to clarify things for me (maybe with some example with beam pointing vertically or horizontally)
A proposal to address issue #3 (add storage of split-aperture data). Made up of these changes:
A potentially significant change to come after this pull request is to support multi-channel sonar systems (e.g., multi-frequency EK60 echosounders).