Open hgerritsen opened 4 years ago
Thanks Hans - will review and add in tonight - can I add you as author of the commit?
Yes, that would be good. I didn’t want to go messing with the code, so I raised it as an issue, rather than requesting write access to the github but if you think it makes sense I would be happy to add it to the script. I also informed the WGSFD chairs by email. Hans
From: Colin Millar [mailto:notifications@github.com] Sent: Wednesday 26 February 2020 15:43 To: ices-eg/wg_WGSFD wg_WGSFD@noreply.github.com Cc: Hans Gerritsen hans.Gerritsen@Marine.ie; Author author@noreply.github.com Subject: Re: [ices-eg/wg_WGSFD] New field in 2020 data call (#23)
Thanks Hans - will review and add in tonight - can I add you as author of the commit?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ices-eg/wg_WGSFD/issues/23?email_source=notifications&email_token=AHA5GPNYVG43YGXNT6HTH2DRE2EWTA5CNFSM4K4IKGV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENAXI6Y#issuecomment-591492219, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHA5GPPZ5S4WYWTMHEA5ZJ3RE2EWTANCNFSM4K4IKGVQ.
Actually you are in the WGSFD sharepoint group - so I can give you write access. That might be easier, as you have actual data to work with - I just have mocked up data.
If are up for that - would you mind looking at adding it to the https://github.com/ices-eg/wg_WGSFD/tree/test-workflow branch?
OK
Done.
thanks so much!!
Hello, The 2020 data call asks for a new field: Anonymized vessel id. From the 2019 WGFSD report i understand that this means that for rows with 2 vessels or less should be disaggregated by vessel (if there are 2) and a vessel id should be provided. I have put together some code, that i think could do the trick and could be added to the workflow script (around line 512). I am not 100% sure that it is ok and there may be a better way but here is my attempt: