Definition of sample_t type for backscatter data in BeamGroup rather than in SonarGroup

ices-publications / SONAR-netCDF4

The SONAR-netCDF4 convention for sonar data

11 stars 11 forks source link

Definition of sample_t type for backscatter data in BeamGroup rather than in SonarGroup #37

Closed lberger29 closed 3 years ago

lberger29 commented 3 years ago

Currently sample_t type is defined in SonarGroup and can be set as:

short for backscatter values in Power or Sv
float for complex samples

This sample_t type should rather be defined in BeamGroup allowing storage of both types of data when running echosounders with multiple transducers using both CW and FM

gavinmacaulay commented 3 years ago

Agreed. Please provide a PR to make this change.

lberger29 commented 3 years ago

@gavinmacaulay this can be closed