search

ices-publications / SONAR-netCDF4

The SONAR-netCDF4 convention for sonar data
11 stars 11 forks source link

Vendor specific table created with a new subgroup, Vendor_specific_Si… #82

Closed SverreBerg closed 2 years ago

SverreBerg commented 2 years ago

…mradWBT, to provide transducer and transceiver information for processing and reference.

gavinmacaulay commented 2 years ago

I edited the tableVendor_specific_SimradWBT_sub_group.adoc using the web. Did that come through?

I'm not sure - two of my suggested changes were marked as resolved, but the text wasn't changed (or did you just not like the suggestions ;). Apart from those, it all looks ok.

SverreBerg commented 2 years ago

I appreciate all suggestions :-) thanks. Not sure which ones I didn't manage to include. Filter gain is not in dB, could be one suggestion left out. (We normally try to make this 1 in our filters) Filter generator version has been changed to a string, as suggested.

gavinmacaulay commented 2 years ago

The two things were the introductory text and the name of the subgroup (changed to SimradWBT). I found that I could commit those changes, so have done so. Have look and check that it looks ok.

SverreBerg commented 2 years ago

Thanks Gavin, your changes look good. Anything more I need to do to complete this proposal?